Update docs crd #29
Merged
Update docs crd #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maximophone
reviewed
Jan 12, 2018
docs/crd/readme.md
Outdated
|
|
||
| ``` | ||
|
|
||
| The predictive unit graph is a tree. Each node is of a particular type with the leaf nodes being models. If the implementation is not specified then a microservice is assumed and you must define a matching named container within the componentSpec above. Each type of PredictiveUnit has a standard set of methods it is expected to manage, see [here](../reference/seldon-deployment.md). |
There was a problem hiding this comment.
with the leaf nodes being models. -> not necessarily but maybe we can pretend this for simplicity?
There was a problem hiding this comment.
No - if we can reword it better.
docs/crd/readme.md
Outdated
| * The implementation. This can be left blank if it will be a microserice as this is the default otherwise choose from the avilable appropriate implementions provided internally. | ||
| * Methods. This can be left blank if you wish to follow the standard methods for your PredictiveNode type : see [here](../reference/seldon-deployment.md). | ||
| * Endpoint. In here you should minimally if this a microservice specify whether the PredictiveUnit will use REST or gRPC. Ports will be defined automatically if not specified. | ||
| * Parameters. Specify any parameters you wish to pass to the PredictiveUnit. These will be passed as added environment variables as a JSON list of key:value pairs with the name PREDICTIVE_UNIT_PARAMETERS. |
There was a problem hiding this comment.
Actually the json list is not of key:value pairs, it has the format:
[
{
name:
value:
type:
},
... ]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.